[jdom-interest] Fast Factory

Jason Hunter jhunter at acm.org
Tue May 27 09:04:13 PDT 2003


Hallvard Trætteberg wrote:

> In the implementation of this that I use (based in Laurent Bihanic's), I
> had to change ContentList to sequence adding to the list and setting the
> parent "correctly". In the official implementation, ContentList first
> sets the parent of the child Element (Element.setParent), then adds it
> to the list. This means that the state of the parent-child relationship
> is incorrect during and after the setParent call, which is a problem
> when overriding setParent to note the change in the Element hierarchy.
> I've changed the order in my JDOM copy, i.e. add to content list first,
> then setParent.
> 
> I'd really like JDOM to change the internals to make my additions work,
> but it is difficult to argue that JDOM currently is wrong, only that id
> support was difficult to add without this change (the alternative would
> be to subclass ContentList, but then there was no way to control which
> ContentList class was instantiated (no Factory)).

Hi Hallvard,

As I recall you wrote about this topic a while ago.  Could you please 
submit a patch against the current codebase?  That's probably the 
easiest way for me to understand what you're really needing, and if it 
doesn't impact anything else I can just check it right in.

-jh-




More information about the jdom-interest mailing list