[jdom-interest] DOCTYPE still giving me the worst headache!

Elliotte Rusty Harold elharo at metalab.unc.edu
Tue Feb 5 06:14:06 PST 2002


At 10:40 PM -0800 2/4/02, Jason Hunter wrote:

>diff -d -u -r1.106 Element.java
>--- src/java/org/jdom/Element.java      2002/01/25 18:42:52     1.106
>+++ src/java/org/jdom/Element.java      2002/02/03 11:03:43
>@@ -215,7 +215,9 @@
>        *         Element name.
>        */
>       public Element setName(String name) {
>-        String reason = Verifier.checkElementName(name);
>+        // Use checkXMLName() instead of checkElementName() here
>+        // because we do need to allow this to contain a colon
>+        String reason = Verifier.checkXMLName(name);
>           if (reason != null) {
>               throw new IllegalNameException(name, "element", reason);
>           }
>
>I read your comment and code to say you're allowing element names to
>contain colons.
>

Weird. Certainly looks like a mistake. I'm not sure what I was 
thinking (if anything). I agree that shouldn't be there.

I have noticed that since I installed the latest WheelMouse extension 
in jEdit it occasionally likes to paste  the contents of the 
clipboard in unexpected places. I think it's doing that when I press 
the mouse wheel by accident. That's perhaps what happened here. 
Normally it results in a syntax error, but in this case I guess I was 
unlucky. Anyway, we agree. Don't check this in. It doesn't make sense.
-- 

+-----------------------+------------------------+-------------------+
| Elliotte Rusty Harold | elharo at metalab.unc.edu | Writer/Programmer |
+-----------------------+------------------------+-------------------+
|          The XML Bible, 2nd Edition (Hungry Minds, 2001)           |
|              http://www.ibiblio.org/xml/books/bible2/              |
|   http://www.amazon.com/exec/obidos/ISBN=0764547607/cafeaulaitA/   |
+----------------------------------+---------------------------------+
|  Read Cafe au Lait for Java News:  http://www.cafeaulait.org/      |
|  Read Cafe con Leche for XML News: http://www.ibiblio.org/xml/     |
+----------------------------------+---------------------------------+



More information about the jdom-interest mailing list