[jdom-commits] CVS update: jdom/src/java/org/jdom

[jhunter at cvs.jdom.org]

Date:	Thursday June 7, 2001 @ 23:41
Author:	jhunter

Update of /home/cvspublic/jdom/src/java/org/jdom
In directory www.nmemonix.com:/tmp/cvs-serv18946

Modified Files:
	Element.java 
Log Message:
Integrated a patch from Jools to fix the following problem, where a
setMixedContent() call could fail.

FYI, Jools appears to have accidentally integrated his FilterList work 
into jdom main instead of jdom-wip so this commit backs out Element to the
pre-FilterList state.

-jh-

> Using the latest revision of Element.java (1.79),
> I get the following stack trace:
> 
> Exception in thread "main" java.lang.NullPointerException
>         at org.jdom.Element.setMixedContent(Compiled Code)
>         at org.jdom.Element.setChildren(Element.java:1009)
>         at Test.main(Test.java:14)
> 
> by runnning this code:
> 
> import java.util.*;
> import org.jdom.Element;
> 
> public class Test {
> 
>     static public void main( String[] args ) {
> 
>         List list = new ArrayList();
>         list.add( new Element( "foo" ) );
> 
>         new Element( "bar" ).setChildren( list );
>     }
> 
> }
> 
> It looks like there should be a null check on oldContent at
> line 919, since it is possible that the Element had no
> content prior to the setChildren call.
> 
> Nick.
> 
> Nick Wormley
> Nistevo Corporation
> nwormley at nistevo.com


===================================================================
File: no file Element.java		Status: Needs Checkout

   Working revision:	1.83	Thu Jun  7 22:41:14 2001
   Repository revision:	1.83	/home/cvspublic/jdom/src/java/org/jdom/Element.java,v

   Existing Tags:
	start                    	(revision: 1.1.1.1)
	jdom                     	(branch: 1.1.1)